Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover uses wrong IP for broadcasts on Windows #584

Open
xobs opened this issue Dec 1, 2019 · 0 comments · May be fixed by #965
Open

Discover uses wrong IP for broadcasts on Windows #584

xobs opened this issue Dec 1, 2019 · 0 comments · May be fixed by #965

Comments

@xobs
Copy link

xobs commented Dec 1, 2019

According to the Valetudo documentation at https://github.com/Hypfer/Valetudo/wiki/Installation-Instructions#flashing-the-firmware-image, the following command should be used to discover the token of an unprovisioned device:

> mirobo --debug discover --handshake true

However, the program attempts to send a broadcast packet to <broadcast>. This maps to 255.255.255.255, which does not work on Windows.

Instead, one must use the actual broadcast device. In this case, it's 192.168.8.255. Changing to this causes discovery to work.

See https://grokbase.com/p/python/python-list/032g91nq60/broadcast-socket-bind-on-windows-broadcast-or for discussion of similar issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants