Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to send user specific attachments #14

Closed
wants to merge 4 commits into from

Conversation

joeirimpan
Copy link

Fixes #13

Copy link
Owner

@rykov rykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you talk a bit about your use case for user-specific attachments, rather than campaign-wide ones?

for i, v := range att {
attName, ok := v.(string)
if !ok {
continue
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a failed cast here shout at least emit a warning.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return error here?

@joeirimpan
Copy link
Author

@rykov
We are using paperboy to send out contract notes (user specific), with a common campaign template. Could also be used to send out invoices, sales report and so on.

I ve accidentally pushed other commits to this PR too. They are

  1. 45acb93 will allow custom layout paths.
  2. 45c0249 allows us to send custom subjects also.

@rykov
Copy link
Owner

rykov commented Jan 26, 2020

@joeirimpan I haven't had a chance to think about how attachments will work, but I liked your idea of allowing custom subjects. So I've just pushed support for subject templating.

Now you can do something like:

subject: Your new username is {{ .Recipient.Params.username }}

or in your case, you customize the whole subject:

subject: {{ .Recipient.Params.subject }}

Thank you for the idea, and I'll follow up on the other changes soon.

@joeirimpan
Copy link
Author

Thanks for looking into this. But we created our own fully-fledged mailing list manager. Please do take a look :)

@joeirimpan joeirimpan closed this Feb 3, 2020
@rykov
Copy link
Owner

rykov commented Feb 3, 2020

@joeirimpan Nice! That's impressive. Happy to have more self-hosted alternatives to all the paid services. Maybe there's a possibility for compatibility/collaboration in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to add user specific attachments
2 participants