Introduce installSecretFn to shorten script when many secrets are used. #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catwith1hat
force-pushed
the
installSecretFn
branch
2 times, most recently
from
acd9bc6
to
01cd0f1
Compare
|
@catwith1hat -- thanks for tackling this. I too am hitting the "Argument list too long" error. Wanted to draw your attention to NixOS/nixpkgs#274765, where I am attempting to solve this problem for any and all activation scripts. |
ryantm
reviewed
Dec 20, 2023
catwith1hat
force-pushed
the
installSecretFn
branch
2 times, most recently
from
b3ee74a
to
75a1aa6
Compare
catwith1hat
force-pushed
the
installSecretFn
branch
from
75a1aa6
to
c71f8f5
Compare
|
I addressed your comments. Please take another look. |
|
Sorry, did I break the Darwin integration? It's not obvious from the logs on the CI what is happening there. Initially, I didn't pay much attention to the broken tests as many github projects have occassionally broken CIs. But now I see that my other PR #242 does succeed with Darwin, so I am now doubting my hypothesis. Sadly, I have no Darwin machine to test or debug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227. Tested with 100 secrets.
Please let me know, if you have some feedback on the style. I didn't try too hard, because I don't know what you prefer.