Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] Use AGENIX_RULES instead of RULES (and maybe rename secrets.nix too) #204

Open
giorgiga opened this issue Oct 5, 2023 · 4 comments

Comments

@giorgiga
Copy link

giorgiga commented Oct 5, 2023

The names RULES and secrets.nix are very generic and unrelated to agenix, to the point that any conscientious programmer can't avoid adding comments like "this variable holds the path to the agenix rules file" or "this is the agenix rules file" (ok, maybe only OCD programmers are affected).

Could you switch to something like AGENIX_RULES and agenix-rules.nix in a future version? (maintaining backwards-compatibility, of course).

@giorgiga
Copy link
Author

giorgiga commented Oct 5, 2023

BTW: I don't have much experience with either go or nix, but this seems easy enough that I can do it if you are willing to accept a PR (and would rather not do it yourself, of course)

@giorgiga
Copy link
Author

giorgiga commented Oct 5, 2023

BTW (since I'm here I'm not opening a separate issue), a second environment variable for holding what ssh key to use (as per the -i option) would be great... since my id_ed25519 is passphrase-protected I generated a key for agenix, but now I have to specify -i ~/.ssh/agenix_ed25519 every time

@ryantm
Copy link
Owner

ryantm commented Oct 8, 2023

Yeah, I think I'd accept such a PR if it had a suitable migration plan and documentation.

@giorgiga
Copy link
Author

That's great - I should be able to work on it this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants