Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on jupyterlite - Can/will it ? #265

Open
oscar6echo opened this issue Jun 20, 2022 · 2 comments
Open

Does not work on jupyterlite - Can/will it ? #265

oscar6echo opened this issue Jun 20, 2022 · 2 comments

Comments

@oscar6echo
Copy link

I tried install jupyterlite_code_formatter in a custom jupyterlite deployment following the official recipe.

Locally, all works as expected.
On jupyterlite, I see the following alert window:
Screenshot-jupyterlab_code_formatter

Can/will jupyterlite_code_formatter work in jupyterlite ?
That would be convenient !

@ryantam626
Copy link
Owner

ryantam626 commented Jul 16, 2022

Didn't know this exists, TIL!

I did a quick investigation, it's unlikely jupyterlite can be supported without a big rework, in order to support it, we also will need to strip out some functionalities.

I will keep this issue open for now and see if jupyterlite matures in a way that it's easily supported.

@jtpio
Copy link
Contributor

jtpio commented Jul 25, 2023

This is likely because jupyterlab-code-formatter requires a server extension to run the linters:

def _jupyter_server_extension_points():
return [{"module": "jupyterlab_code_formatter"}]

It would be interesting to check if some of the linters can be run in the browser directly (for example with Pyodide). If so then the extension could be configured to provide a way to format the code in the browser directly, and could enable using it in lite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants