Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSMutableArray #100

Open
agg23 opened this issue Jul 20, 2023 · 1 comment
Open

NSMutableArray #100

agg23 opened this issue Jul 20, 2023 · 1 comment

Comments

@agg23
Copy link
Contributor

agg23 commented Jul 20, 2023

Is there a particular reason why NSArray is being used, and not NSMutableArray? The pattern for NSDictionary was to use the mutable variant, and unless we're worried about the perf impact of the mutable type (which I think is negligible, especially given what this code is doing), I think that NSMutableArray should be used instead.

The only problem I foresee with this (and NSMutableDictionary has the same issue) is if a caller receives a immutable type through an API call, we cast it on the Rust side to be mutable, which means users can call insert or whatever on them.

@ryanmcgrath
Copy link
Owner

Similar to #99, some of the thinking that went into these is dated by now and I'm open to changing things up. Offhand I can't think of a particular reason why NSMutableArray couldn't be used instead - I've vague memories of tinkering with it and honestly forget why I backed away.

Which means there very well could be a reason, but the best way at this point to determine it is just to branch/alter the code and see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants