Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Upgrade some packages without breaking things #90

Open
ryanhugh opened this issue Aug 13, 2019 · 0 comments
Open

Upgrade some packages without breaking things #90

ryanhugh opened this issue Aug 13, 2019 · 0 comments
Assignees

Comments

@ryanhugh
Copy link
Owner

ryanhugh commented Aug 13, 2019

I just tried to upgrade all the packages, but a few broke a significant amount of things when I upgraded them:

From yarn outdated:

async 2.6.3 to 3.1.0 https://caolan.github.io/async/

  • Upgrading this package causes arrow functions (=>) to be compiled into the output with yarn build which breaks the site in old browsers. The only part of this package we are using is async.retry, so maybe its worth just getting that functionality from somewhere else

cheerio 0.22.0 to 1.0.0-rc.3 https://github.com/cheeriojs/cheerio#readme

  • I just don't want to upgrade this one to a release candidate, going to wait until after v1 is officially released.

domutils 1.7.0 to 2.0.0 https://github.com/fb55/domutils#readme

  • This one no longer exports anything when you import it with ES6 imports after its upgraded? This is a weird package, needs to be removed from the codebase anyway.

htmlparser2 3.10.1 to 4.0.0 https://github.com/fb55/htmlparser2#readme

  • Breaks a newly added unit test for employees.js
@ryanhugh ryanhugh self-assigned this Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant