You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When you open a video in fullscreen on a maximised client and then exit out of full screen the top bar is missing
Expected behavior
the top bar should be shown again after leaving fullscreen mode
Screenshots
If applicable, add screenshots to help explain your problem.
Distro (please complete the following information):
i am on manjaro, but the bug should probably happen on all distros
Additional context
The bug happens because in awesome/ui/panels/top-panel/init.lua the function remove_top_panel() hides the top panel when either the client is maximised or in fullscreen.
local function remove_top_panel(c)
if c.fullscreen or c.maximized then
c.screen.top_panel.visible = false
else
c.screen.top_panel.visible = true
end
end
But the function is only executed when the client is put in fullscreen
this depends on how u want the ui to behave, but i believe the intended way would be option 2)
P.S.:
in the same location there is a very similar function called add_top_panel() which also checks for both c.maximized and c.fullscreen. This might cause a bug aswell, but since I don't know what client.connect_signal("request::unmanage", add_top_panel) does, I am not able to test this assumption
The text was updated successfully, but these errors were encountered:
Hey man, thank u, for me it worked. In the piece of code inside awesome/ui/panels/top-panel/init.lua that you described, I change the piece of code that said:
local function remove_top_panel(c)
if c.fullscreen or c.maximized then
c.screen.top_panel.visible = false
else
c.screen.top_panel.visible = true
end
end
to:
local function remove_top_panel(c)
if c.fullscreen then
c.screen.top_panel.visible = false
else
c.screen.top_panel.visible = true
end
end
And now the top-panel appears when I get out of fullscreen, thanks, It's been something that bodered me for days
Describe the bug
When you open a video in fullscreen on a maximised client and then exit out of full screen the top bar is missing
Expected behavior
the top bar should be shown again after leaving fullscreen mode
Screenshots
If applicable, add screenshots to help explain your problem.
Distro (please complete the following information):
i am on manjaro, but the bug should probably happen on all distros
Additional context
The bug happens because in awesome/ui/panels/top-panel/init.lua the function remove_top_panel() hides the top panel when either the client is maximised or in fullscreen.
But the function is only executed when the client is put in fullscreen
there are 2 ways of fixing this:
below the line with fullscreen
from the function
this depends on how u want the ui to behave, but i believe the intended way would be option 2)
P.S.:
in the same location there is a very similar function called
add_top_panel()
which also checks for both c.maximized and c.fullscreen. This might cause a bug aswell, but since I don't know whatclient.connect_signal("request::unmanage", add_top_panel)
does, I am not able to test this assumptionThe text was updated successfully, but these errors were encountered: