Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version release keeps on showing Pop up after installing new update #19

Open
ManjunathaKaliwal opened this issue Jun 16, 2022 · 9 comments

Comments

@ManjunathaKaliwal
Copy link

ManjunathaKaliwal commented Jun 16, 2022

Describe the bug
Recently we have integrated updates framework, so last version working fine but recently observed issue for all the users. We have released new version 3.0.32 with release notes,
Issue - All user updated app to 3.0.32 but still it's showing pop as new version available. please let us know the issue?

Smartphone (please complete the following information):

  • iOS
  • Version 15.4
  • iPhone 11

Additional context
Add any other context about the problem here.

@ManjunathaKaliwal
Copy link
Author

Hi Team any update on this?

@pedrofneves
Copy link

+1

@rwbutler
Copy link
Owner

Hi @pedrofneves would you be willing to share your implementation?

@rwbutler
Copy link
Owner

Or @ManjunathaKaliwal?

@rwbutler
Copy link
Owner

I'd be happy to take a look

@pedrofneves
Copy link

@rwbutler of course:

Updates.appStoreId = env.infoForKey(.appStoreID)
Updates.notifying = .always
Updates.comparingVersions = [.build, .patch, .minor, .major]
Updates.updateType = .hard
Updates.checkForUpdates { result in
    UpdatesUI.promptToUpdate(result, presentingViewController: self)
}

The users complain when we deploy a patch modified version, e.g.: from 1.2.0 to 1.2.1

@rwbutler
Copy link
Owner

@pedrofneves Am I right in thinking that you only want users to be notified when there is an increase in the patch number? In that case, the configuration you want is:

Updates.comparingVersions = .patch

The way things are configured in the sample above - your users will be notified every time the build number changes.

@pedrofneves
Copy link

No. The problem is when the users install the new patched version Updates keep prompting the users to update the same version. Exactly as described by ManjunathaKaliwal.

@CavalcanteLeo
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants