Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel completion callback #16

Open
joostfunkekupper opened this issue Oct 18, 2021 · 0 comments
Open

Cancel completion callback #16

joostfunkekupper opened this issue Oct 18, 2021 · 0 comments

Comments

@joostfunkekupper
Copy link

Is your feature request related to a problem? Please describe.
It would be nice if we could handle the difference between a successful and cancel callback. At the moment there is only a single completion callback, which get's ignored if you have the updateType set to .hard.

Even so, when the SafariViewController is cancelled, that completion callback is not being used anyway, so you get no feedback.

Describe the solution you'd like
Have a clear successCallback and dismissCallback which can be used to know if the user accepted or declined the update.

Describe alternatives you've considered
Unless I've missed something, I haven't considered any alternatives.

Additional context
None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant