Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS1.3 performance problem #1751

Open
zh-jq-b opened this issue Jan 17, 2024 · 8 comments
Open

TLS1.3 performance problem #1751

zh-jq-b opened this issue Jan 17, 2024 · 8 comments

Comments

@zh-jq-b
Copy link

zh-jq-b commented Jan 17, 2024

See https://bytedance.larkoffice.com/docx/NEqXdDyq8op8mwx0XTWcwgionnf.

The tls1.3 performance isn't as good as OpenSSL 1.1.x when testing at high concurrency.

@djc
Copy link
Member

djc commented Jan 17, 2024

Why are you not testing aws-lc-rs support? Are your results in line with https://github.com/aochagavia/rustls-bench-results?

@zh-jq-b
Copy link
Author

zh-jq-b commented Jan 17, 2024

Why are you not testing aws-lc-rs support?

The test is against rustls 0.21 branch and I will try 0.22 ring & 0.22 aws-lc in the next few days.

We did test 0.22 here https://bytedance.larkoffice.com/docx/TSqmdLNIyozJdCx4rzqcjPyonjd, and the difference between 0.21&0.22ring&0.22aws-lc is not too much.

Are your results in line with https://github.com/aochagavia/rustls-bench-results?

No, I haven't checked that.

@zh-jq-b
Copy link
Author

zh-jq-b commented Jan 18, 2024

I also add tls1.2 test result here https://bytedance.larkoffice.com/docx/NEqXdDyq8op8mwx0XTWcwgionnf.
The rustls 1.2 performance is better than tls1.3 & openssl (which is expected).
There are no much RPS difference between rustls 0.21 & rustls 0.22 ring & rustls 0.22 aws-lc in our test.

@djc
Copy link
Member

djc commented Jan 18, 2024

There have been some recent changes on the main branch. Would it be hard to try this with current rustls main?

@zh-jq-b
Copy link
Author

zh-jq-b commented Jan 18, 2024

There have been some recent changes on the main branch. Would it be hard to try this with current rustls main?

The max RPS (ring) is still around 54000.

I just bump the version here bytedance/g3@0c2feaf without any API changes.

@cpu
Copy link
Member

cpu commented Feb 7, 2024

Are you building with gcc or clang?

@zh-jq-b
Copy link
Author

zh-jq-b commented Feb 8, 2024

Are you building with gcc or clang?

I didn't set a custom CC, so it should be gcc.

@briansmith
Copy link
Contributor

I didn't set a custom CC, so it should be gcc.

recent clang should be faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants