Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color rendering mismatch on all odd vertical pixel count-sized resolutions #6964

Closed
skull-squadron opened this issue Jan 23, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@skull-squadron
Copy link

Bug Description

Every vertical resolution with an odd number of pixels (default for half resolution on 16" MBP m1) renders color-containing image data offset up.

Grayscale items will be in their original position relative to the framebuffer, however color-containing regions appear offset.

How to Reproduce

Remote

  1. Set mac built-in display to resolution 1728x1117
  2. Start background service

Local

  1. Connect to remote from a Windows client

Expected Behavior

Colors rendered on the remote display should line up similarly to even vertical pixel-sized displays.

Operating system(s) on local side and remote side

Windows 11 22H2 -> macOS Sonoma 14.2.1

RustDesk Version(s) on local side and remote side

1.2.3 -> 1.2.3

Screenshots

Screenshot 2024-01-23 010524
Screenshot 2024-01-23 010235
Screenshot 2024-01-23 010302
Screenshot 2024-01-23 010320
Screenshot 2024-01-23 010342
Screenshot 2024-01-23 010400
Screenshot 2024-01-23 010420
Screenshot 2024-01-23 010433
Screenshot 2024-01-23 010453
Screenshot 2024-01-23 010509

Additional Context

  • Local display: 5120x1440 (SDR) external secondary, 2560x1440 (HDR-capable) primary (disabled)
  • Hardware codec: Enabled *
  • ID server: LAN-local Docker container
  • Relay server: LAN-local Docker container
  • API server: (blank)
  • Key: (blank)
  • Encryption: disabled (Running locally only)
  • Direct IP: enabled
  • Scale: Scale adaptive *
  • Image quality: Good image quality *
  • Codec: Auto #

* No impact with any other setting
# AV1 displayed in screenshots. VP8 produces a similar but different corruption. VP9 corruption same as VP8.

@skull-squadron skull-squadron added the bug Something isn't working label Jan 23, 2024
@rustdesk rustdesk added the duplicate This issue or pull request already exists label Jan 23, 2024
@rustdesk rustdesk reopened this Jan 23, 2024
@rustdesk
Copy link
Owner

rustdesk commented Jan 23, 2024

@21pages I thought same to #6518, but seems not, please check

@rustdesk rustdesk removed the duplicate This issue or pull request already exists label Jan 23, 2024
@rustdesk
Copy link
Owner

Sorry, this is related to #5246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants