Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace dependency ureq with reqwest #863

Closed
wants to merge 4 commits into from
Closed

replace dependency ureq with reqwest #863

wants to merge 4 commits into from

Conversation

StringKe
Copy link
Contributor

@StringKe StringKe commented Oct 24, 2023 •
edited

Replaced ureq with reqwest since the ureq upstream ring dependency does not compile under wasm.

The svg modules unit test has passed, but the wasm build test has not, and I have no idea how the project tests wasm.

2023/10/24: upstream ring already supports wasm, but ureq is not updated at the moment

fix: #845

@StringKe StringKe marked this pull request as draft October 24, 2023 07:05
@StringKe StringKe closed this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The ureq dependency in the svg feature does not compile wasm
1 participant
@StringKe