Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose API to restore database from backups #135

Closed
benoitc opened this issue Aug 27, 2017 · 7 comments
Closed

Expose API to restore database from backups #135

benoitc opened this issue Aug 27, 2017 · 7 comments

Comments

@benoitc
Copy link

benoitc commented Aug 27, 2017

the backup module can backup and has restore options, but how do we backup?

BusyJay pushed a commit to BusyJay/rust-rocksdb that referenced this issue Nov 4, 2017
@iSynaptic
Copy link
Member

Can you provide more detail? What are you trying to do?

@rohitjoshi
Copy link
Contributor

How do I restore from an existing backup directory? I don't see pub unsafe extern "C" fn rocksdb_backup_engine_restore_db_from_latest_backup() is made available in the Rust interface.

@iSynaptic
Copy link
Member

I can see that the library doesn't expose the ability to restore an backup. Looks like the work has been started but not finished. I've labeled this as a bug. Anyone is free to take on fixing this, otherwise I will plan on it once other in-flight work is completed.

@iSynaptic iSynaptic changed the title restore a db? Expose API to restore database from backups Feb 24, 2019
@rohitjoshi
Copy link
Contributor

I have implemented this on my local branch. I will submit a PR.

@iSynaptic
Copy link
Member

Looks like this will be addressed in #249 by @rohitjoshi.

@rohitjoshi
Copy link
Contributor

@iSynaptic I am close #249 and splitting into two different PRs.
Submitted #272 for this issue.

@iSynaptic
Copy link
Member

Fixed by #272.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants