Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

RLS analysis makes everything on the bottom bar jiggle #81

Closed
sunjay opened this issue Jul 17, 2017 · 11 comments
Closed

RLS analysis makes everything on the bottom bar jiggle #81

sunjay opened this issue Jul 17, 2017 · 11 comments

Comments

@sunjay
Copy link
Member

sunjay commented Jul 17, 2017

Example:
peek 2017-07-17 10-26

Would it be possible to use something fixed width or just remove the loading spinner altogether? The constant motion is very distracting.

@sophiajt
Copy link

I wonder if the font for the bottom can be set to fixed width

@Xanewok
Copy link
Member

Xanewok commented Jul 17, 2017

Not sure if this is currently possible. It's possible to change the color of the statusbar, embed octicons in status bar text, but changing font is something that's still planned, if I'm not mistaken (relevant issues).

We could technically switch to ['/', '\\'] spinner though 😛

@sunjay
Copy link
Member Author

sunjay commented Jul 17, 2017

This icon looks like a spinner: https://octicons.github.com/icon/sync/

@Xanewok
Copy link
Member

Xanewok commented Jul 17, 2017

It does indeed, but my first impression looking at the icon is that it's related to either synchronization or reloading and we can't animate it, which I believe is important from UX standpoint to show user that's something being actively processed, so I don't believe it's a good idea to replace current spinner with this icon.

I think we should investigate this a bit, maybe toying with whitespaces will do the trick. If not, I guess we could settle for poor man's 2-character spinner and eventually wait for font theme support to land on vscode side.

@Xanewok
Copy link
Member

Xanewok commented Jul 17, 2017

Then again maybe you're right and we could try and experiment with:

  1. https://octicons.github.com/icon/zap/
  2. https://octicons.github.com/icon/sync/
  3. https://octicons.github.com/icon/check/

for the current starting up > working > done cycle

@nrc
Copy link
Member

nrc commented Jul 17, 2017

Where does the --NORMAL MODE-- come from? I think this would be fine if there weren't text to the right of the spinner (which we avoid in the extension).

@sunjay
Copy link
Member Author

sunjay commented Jul 17, 2017

@nrc That's from the vim mode extension. I don't think you have full control over that because I see the items on the bottom bar switch position all the time. Seems like whatever is last added or changed always gets moved to the right. (I just started using vscode from atom so this all seems like pretty weird behavior to me.)

@nrc
Copy link
Member

nrc commented Jul 17, 2017

I would prefer to use a spinner rather than the octirons, for one thing VSCode uses a similar ascii spinner in some other situations. I wonder if we could use some fancy unicode characters that always render fixed width?

@Xanewok
Copy link
Member

Xanewok commented Jul 17, 2017

I'm bad at internet and don't know how to quickly create a cropped high-res gif, so I'll just leave this here: #84. Looks even kind of decent, but I guess we could get more fancy with this 😉

@nrc
Copy link
Member

nrc commented Jul 18, 2017

Should be fixed by #84

@nrc nrc closed this as completed Jul 18, 2017
@sunjay
Copy link
Member Author

sunjay commented Jul 18, 2017

Thanks everyone!

Xanewok pushed a commit to Xanewok/rls-vscode that referenced this issue Mar 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants