Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Why does it install Nightly? #305

Closed
mcclure opened this issue Apr 28, 2018 · 4 comments · Fixed by #365
Closed

Why does it install Nightly? #305

mcclure opened this issue Apr 28, 2018 · 4 comments · Fixed by #365
Labels

Comments

@mcclure
Copy link

mcclure commented Apr 28, 2018

I installed this vscode extension. It is nice! However, I noticed: When I first installed it, it installed first rust nightly, then it installed RLS. It was as if the vscode setup believed that nightly was necessary in order to boot RLS. However, a Rust user I talked to informed me that RLS has not required nightly since Rust 1.21. The RLS instructions https://github.com/rust-lang-nursery/rls suggest only that you need to install the most current version.

Is the Rust Nightly install actually necessary, or is this just a vestigial quirk of when RLS required nightly?

@nrc nrc added the bug label Apr 29, 2018
@nrc
Copy link
Member

nrc commented Apr 29, 2018

I think this is a vestigial quirk, will investigate...

@awbacker
Copy link

awbacker commented May 10, 2018

Just installed v0.4.2 and got I got two messages from "Rust (rls) (Extension)":

nightly toolchain not installed. install?"

and

RLS could not set RUST_SRC_PATH for Racer because it could not read the Rust sysroot.

image

I'm on osx, with the latest of vscode and just updated with rustup.


I was able to fix this by setting "rust-client.channel": "stable" in user settings.

This is what I actually did, though I'm sure there is a simpler way. I doubt installing the components manually is necessary.

  • Installed the extension (and got the error popups)
  • Ran rustup component add rls-preview rust-analysis rust-src from the command line
  • Set the user-setting "rust-client.channel": "stable"
  • Disabled the extension and reloaded the workspace
  • Re-enabled the extension and the workspace
  • Working!

@segevfiner
Copy link
Contributor

I think the extension parses the output of rustup show but it probably changed...

rustup doesn't seem to have stable machine parsable output for this, see rust-lang/rustup#450.

See: https://github.com/rust-lang-nursery/rls-vscode/blob/3dc3987eb215cb4d72252ea17e853e19023cea48/src/rustup.ts#L193-L212

@andrekoehler
Copy link

It would be great if "rust-client.channel": "stable" was the default setting because rustup installs the stable toolchain by default as well.

segevfiner added a commit to segevfiner/rls-vscode that referenced this issue Jul 11, 2018
fj pushed a commit to fj/rls-vscode that referenced this issue Feb 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants