Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add clippy job to rust.yml workflow #1951

Merged
merged 2 commits into from May 12, 2024

Conversation

hamirmahal
Copy link
Contributor

closes #1950.

clippy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally used actions/checkout@v4 here because actions/checkout@v3 uses a deprecated Node.js version.

@hamirmahal
Copy link
Contributor Author

@mo8it what are your thoughts on this pull request?

@mo8it
Copy link
Contributor

mo8it commented May 7, 2024

Hi @hamirmahal, I am a new maintainer and didn't deal with the CI configuration yet. My priority is to release version 6 soon. I will look at this PR afterwards.

@mo8it mo8it merged commit c2414b8 into rust-lang:main May 12, 2024
6 checks passed
@hamirmahal hamirmahal deleted the ci/add-clippy-job-to-workflow branch May 12, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI check for clippy issues
2 participants