Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/ui/attributes/unix_sigpipe/unix_sigpipe-inherit.rs no longer passes locally #124465

Closed
matthiaskrgr opened this issue Apr 28, 2024 · 6 comments · Fixed by #124505
Closed
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug.

Comments

@matthiaskrgr
Copy link
Member

matthiaskrgr commented Apr 28, 2024

I checked out the master branch and ran ./x.py test ui and the test failed:

iiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiii 16632/16763
iiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiii 16720/16763
iiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiii
[ui] tests/ui/attributes/unix_sigpipe/unix_sigpipe-inherit.rs ... F


failures:

---- [ui] tests/ui/attributes/unix_sigpipe/unix_sigpipe-inherit.rs stdout ----

error: test run failed!
status: exit status: 101
command: cd "/home/matthias/vcs/github/rust/build/x86_64-unknown-linux-gnu/test/ui/attributes/unix_sigpipe/unix_sigpipe-inherit" && RUST_TEST_THREADS="16" "/home/matthias/vcs/github/rust/build/x86_64-unknown-linux-gnu/test/ui/attributes/unix_sigpipe/unix_sigpipe-inherit/a"
stdout: none
--- stderr -------------------------------
auxiliary/bin/assert-inherit-sig_dfl: symbol lookup error: /home/matthias/vcs/github/rust/build/x86_64-unknown-linux-gnu/test/ui/attributes/unix_sigpipe/unix_sigpipe-inherit/auxiliary/libsigpipe_utils.so: undefined symbol: _ZN4core9panicking14panic_nounwind17hcffcae1ece7a0552E
thread 'main' panicked at /home/matthias/vcs/github/rust/tests/ui/attributes/unix_sigpipe/unix_sigpipe-inherit.rs:28:5:
assertion failed: cmd.status().unwrap().success()
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
------------------------------------------



failures:
    [ui] tests/ui/attributes/unix_sigpipe/unix_sigpipe-inherit.rs

test result: FAILED. 4 passed; 1 failed; 16758 ignored; 0 measured; 0 filtered out; finished in 414.59ms

Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
Build completed unsuccessfully in 0:00:10

this was on 6c90ac8

@matthiaskrgr matthiaskrgr added the C-bug Category: This is a bug. label Apr 28, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 28, 2024
@ehuss
Copy link
Contributor

ehuss commented Apr 28, 2024

I am having the same problem on aarch64-apple-darwin.
cc @Enselic, this started with #123316.

@Enselic
Copy link
Member

Enselic commented Apr 28, 2024

@ehuss @matthiaskrgr I can't reproduce this in a clean ubuntu container. Can you? If not, probably something specific about your environments is causing this? The test did pass bors, after all.

docker run -it ubuntu
apt-get update -y && apt-get install -y git python3 curl build-essential
git clone --depth 1 https://github.com/rust-lang/rust.git ; cd rust
./x test --set rust.verbose-tests=true tests/ui/attributes/unix_sigpipe/unix_sigpipe-inherit.rs
running 1 tests
test [ui] tests/ui/attributes/unix_sigpipe/unix_sigpipe-inherit.rs ... ok

@spastorino
Copy link
Member

This is also happening in dev-desktop-us-1.infra.rust-lang.org, where would be easy to reproduce I guess.

@ehuss
Copy link
Contributor

ehuss commented Apr 28, 2024

I think it might be an issue with caching, perhaps of the aux-bins. The following should reliably reproduce it:

apt-get update -y && apt-get install -y git python3 curl build-essential
git clone https://github.com/rust-lang/rust.git
cd rust
git checkout 7bb4f0889e8b133c5b03c46f31f2ae6432c00219
./x test tests/ui/attributes/unix_sigpipe
git checkout ce609db948f210807f61da999c57bd4ae5216254
./x test tests/ui/attributes/unix_sigpipe

@Zalathar
Copy link
Contributor

If I do this, the test goes from failing to passing:

rm -r build/aarch64-apple-darwin/test/ui/attributes/unix_sigpipe/unix_sigpipe-inherit/auxiliary
x test tests/ui/attributes/unix_sigpipe/unix_sigpipe-inherit.rs

So yeah, looks like a problem with cache invalidation of something in that directory.

@Enselic
Copy link
Member

Enselic commented Apr 29, 2024

Thanks for the reproducer. This fixes it for me: #124505

The failure is because there is an old .so file lying around: ./build/x86_64-unknown-linux-gnu/test/ui/attributes/unix_sigpipe/unix_sigpipe-inherit/auxiliary/libsigpipe_utils.so

It should use: ./build/x86_64-unknown-linux-gnu/test/ui/attributes/unix_sigpipe/unix_sigpipe-inherit/auxiliary/bin/libsigpipe_utils.so

By removing the old and obsolete file, the test passes.

@bors bors closed this as completed in 9084601 Apr 29, 2024
@saethlin saethlin added A-testsuite Area: The testsuite used to check the correctness of rustc and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants