Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

something is weird about llvm submodule handling #124162

Open
matthiaskrgr opened this issue Apr 19, 2024 · 4 comments
Open

something is weird about llvm submodule handling #124162

matthiaskrgr opened this issue Apr 19, 2024 · 4 comments
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@matthiaskrgr
Copy link
Member

I just observed the following:
I did a git pull and it downloaded a bunch of llvm submodule data.
Afterwards, I did an x.py install, I'm not sure what happened with the llvm submodule but llvm did NOT get rebuilt, so probably nothing touched it?
Then, I did another x.py install afterwards, without touching anything on the repo and THAT did start rebuilding llvm again.

I'm having a gut feeling that we should have had rebuilt llvm already on the first x.py install but I don't know what the underlying issue is.

cfg:

[llvm]
download-ci-llvm = false
assertions = true
ninja = true
targets = "X86"
link-jobs = 16
cflags = "-march=native" # -D_GLIBCXX_DEBUG
cxxflags = "-march=native" # -D_GLIBCXX_DEBUG
ldflags = "-march=native" # -D_GLIBCXX_DEBUG
polly = false
[build]
dist-stage = 2
install-stage = 2
extended = true
tools = ["cargo", "clippy", "rustfmt", "analysis", "src", "miri"] # + "rust-demangler" if `profiler`
low-priority = true
[install]
prefix = "/home/gh-matthiaskrgr/.rustup/toolchains/local-debug-assertions"
sysconfdir = "etc"
[rust]
debug = true
debug-assertions = true
debug-assertions-std = true
overflow-checks = true
overflow-checks-std = true
debuginfo-level = 1
codegen-backends = ["llvm", "cranelift"]
backtrace-on-ice = true
verify-llvm-ir = true
lto = "thin"
[target.x86_64-unknown-linux-gnu]
[dist]
compression-formats = ["xz"]
```
@matthiaskrgr matthiaskrgr added the C-bug Category: This is a bug. label Apr 19, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 19, 2024
@matthiaskrgr matthiaskrgr added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Apr 19, 2024
@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 19, 2024
@onur-ozkan
Copy link
Member

Was the HEAD older than #122632 ?

@matthiaskrgr
Copy link
Member Author

I guess that could have been the case 🤔

@onur-ozkan
Copy link
Member

I guess that could have been the case 🤔

Then let's close the issue for now. If the problem recurs, we can reopen it.

@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented May 23, 2024

Just happened again 🫠
edit: as I updated form 8387315 to ed172db then did install , ctrl+c , install

@matthiaskrgr matthiaskrgr reopened this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

3 participants