Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for RFC 3484: Unsafe Extern Blocks #123743

Open
1 of 9 tasks
traviscross opened this issue Apr 10, 2024 · 1 comment
Open
1 of 9 tasks

Tracking Issue for RFC 3484: Unsafe Extern Blocks #123743

traviscross opened this issue Apr 10, 2024 · 1 comment
Assignees
Labels
A-edition-2027 Area: The 2027 edition B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. F-unsafe_extern `#![feature(unsafe_extern)]` S-tracking-impl-incomplete Status: The implementation is incomplete. S-tracking-needs-documentation Status: Needs documentation. S-tracking-needs-migration-lint Status: This item needs a migration lint. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@traviscross
Copy link
Contributor

traviscross commented Apr 10, 2024

This is a tracking issue for the RFC 3484: Unsafe Extern Blocks

The feature gate for the issue is #![feature(unsafe_extern)].

About tracking issues

Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

  • Extern declarations are actually always unsafe and able to cause UB regardless of edition. This RFC doesn't have a specific answer on how to improve pre-2027 code.
    • could use attributes

Implementation history

cc @Lokathor @spastorino

@traviscross traviscross added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-lang Relevant to the language team, which will review and decide on the PR/issue. A-edition-2024 Area: The 2024 edition labels Apr 10, 2024
@oli-obk
Copy link
Contributor

oli-obk commented Apr 29, 2024

I have been reviewing some work (and the required refactorings), and the refactorings need refactorings of their own (not sure how many layers of turtles are needed, but it's not all the way down) 😓

The only way to get it done in time is to not do refactorings before, but just leave FIXMEs, which doesn't sit right with me. So:

let's not do this for the 2024 edition, but jump straight into implementing the 2027 edition

@oli-obk oli-obk added A-edition-2027 Area: The 2027 edition and removed A-edition-2024 Area: The 2024 edition labels Apr 29, 2024
@traviscross traviscross added F-unsafe_extern `#![feature(unsafe_extern)]` B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. labels May 6, 2024
@traviscross traviscross added S-tracking-impl-incomplete Status: The implementation is incomplete. S-tracking-needs-migration-lint Status: This item needs a migration lint. S-tracking-needs-documentation Status: Needs documentation. labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-edition-2027 Area: The 2027 edition B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. F-unsafe_extern `#![feature(unsafe_extern)]` S-tracking-impl-incomplete Status: The implementation is incomplete. S-tracking-needs-documentation Status: Needs documentation. S-tracking-needs-migration-lint Status: This item needs a migration lint. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants