Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x build unstable-book is too lazy and doesn't reflect subsequent edits #122367

Closed
Zalathar opened this issue Mar 12, 2024 · 1 comment · Fixed by #122378
Closed

x build unstable-book is too lazy and doesn't reflect subsequent edits #122367

Zalathar opened this issue Mar 12, 2024 · 1 comment · Fixed by #122378
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Zalathar
Copy link
Contributor

Zalathar commented Mar 12, 2024 •
edited

(Via https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap/topic/Is.20.60x.20doc.20unstable-book.60.20broken.3F)

If I run x doc unstable-book with a clean ./build directory, it seems to work fine.

But if I then edit or create files in ./src/doc/unstable-book, and then re-run x doc unstable-book, the command appears to succeed, but doesn't actually re-generate the book. Any edits to the book after the first build do not appear in the output.

As a workaround, I have to do rm -r build/aarch64-apple-darwin/doc/unstable-book/ to force the book to actually rebuild.

@rustbot label +T-bootstrap
@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 12, 2024
@Zalathar
Copy link
Contributor Author

cc @albertlarsan68

@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 12, 2024
@clubby789 clubby789 mentioned this issue Mar 12, 2024
Merged
@bors bors closed this as completed in cf3d178 Mar 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 12, 2024
@rust-timer
Unrolled build for rust-lang#122378
bd541d3 
Rollup merge of rust-lang#122378 - clubby789:rustbook-rebuild, r=onur-ozkan

Properly rebuild rustbooks

Fixes rust-lang#122367

If the book was out of date but the tool was up to date, this would evaluate to `!(false || true)` == `!true` == `false` and not rebuild.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly rebuild rustbooks clubby789/rust
3 participants
@Zalathar @onur-ozkan @rustbot