This repository has been archived by the owner on Nov 21, 2018. It is now read-only.
make Docker install valgrind #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checked for a `valgrind --version` on prod-slave-linux-3 but it's not installed there.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
We'll want to ensure this works ok in dev on 32 and 64 bit as I think hokiness was required in the past to get a 32-bit valgrind working. I've pushed this with the tag 2015-11-23 as well |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked for a
valgrind --versionon prod-slave-linux-3 but it's notinstalled there.
fixes #45