Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed release files can only compile for musl #355

Open
addisoncrump opened this issue Jan 3, 2024 · 3 comments · May be fixed by #365
Open

Distributed release files can only compile for musl #355

addisoncrump opened this issue Jan 3, 2024 · 3 comments · May be fixed by #365

Comments

@addisoncrump
Copy link

addisoncrump commented Jan 3, 2024

See: astral-sh/ruff#9368

It seems that binstall (which pulls from GitHub since the release) installs the musl copies distributed in the latest release, but the released files can only build musl-targeting fuzzers.

I would expect that the distributed files should be compatible with any toolchain.

@taiki-e
Copy link

taiki-e commented Mar 2, 2024

I have tested all musl binaries (0.11.2-0.12.0), and they all have this issue.

And, this is due to the following code using the target that is used to build cargo-fuzz itself as the default target.

/// The default target to pass to cargo, to workaround issue #11.
pub fn default_target() -> &'static str {
current_platform::CURRENT_PLATFORM
}

The more correct way here is to get host triple from the output of cargo --version --verbose, like this.

(Workaround is passing --target x86_64-unknown-linux-gnu to cargo fuzz.)

@taiki-e
Copy link

taiki-e commented Mar 2, 2024

The more correct way here is to get host triple from the output of cargo --version --verbose, like this.

However, to provide the fully same behavior as the default target selection in cargo, a library such as cargo-config2 is needed because we need to handle config while handling its hierarchical structure and environment variables.

@taiki-e
Copy link

taiki-e commented Mar 2, 2024

Filed #365 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants