Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What to do with debug_assert!s inside this crate? #154

Open
fitzgen opened this issue Jun 13, 2023 · 0 comments
Open

What to do with debug_assert!s inside this crate? #154

fitzgen opened this issue Jun 13, 2023 · 0 comments

Comments

@fitzgen
Copy link
Member

fitzgen commented Jun 13, 2023

thought: should we be including this? fuzzing is usually run with debug assertions on so the debug_assert doesn't get us much. I am comfortable with more thoroughly documenting the safety situation instead

Originally posted by @Manishearth in #151 (comment)

Another option is adding a test_assert! macro that is guarded on cfg(test), so it only runs for this crate's tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fitzgen