-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Think about how MiniscriptKey interacts with Musig keys #427
Comments
It seems like the best solution would be to support parsing as a new struct struct KeyExpr<Pk: MiniscriptKey> {
SingleKey(Pk),
Musig(Vec<KeyExpr<Pk>>),
}
|
This sounds like the right direction to me. The keyhash stuff is a bit ugly but I think that's inherent to the problem domain. |
SarcasticNastik
added a commit
to SarcasticNastik/rust-miniscript
that referenced
this issue
Jun 9, 2022
As suggested in rust-bitcoin#427, this refactor helps to incorporate musig in the codebase.
SarcasticNastik
added a commit
to SarcasticNastik/rust-miniscript
that referenced
this issue
Jun 9, 2022
As suggested in rust-bitcoin#427, this refactor helps to incorporate musig in the codebase.
sanket1729
added a commit
that referenced
this issue
Jun 17, 2022
8d0cf06 Remove `ForEach` Trait (Aman Rojjha) 5cb2bcf Refactor PkH to include key. (Aman Rojjha) 09299b0 Refactor ForEach to contain only Pk. (Aman Rojjha) 701c9cc Remove un-necessary lifetimes (Aman Rojjha) ca16bd8 Fix formatter configuration errors with latest nightly (sanket1729) Pull request description: As suggested in #427, this refactor helps to incorporate musig in the codebase. ACKs for top commit: apoelstra: ACK 8d0cf06 sanket1729: ACK 8d0cf06. The last commit message should be `Remove ForEach struct` instead of `Remove ForEach trait`. But won't holdoff this over that. Tree-SHA512: 645974d9055e0458f64e214d95a73647420d46f05246be6809ae11dbfd8dacc05500c5e9f9f1b10b532b539b2d30883c014177a33e7666aea8ae383722910ff9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Integrating musig2 keys with the existing API introduces a couple of new challenges:
Terminal::Pk(Pk)
in our miniscript decoding. This means we should parsemusig(A,B,C)
as a single Pk.A
,B
andC
.Seems like we might to re-design some parts of the codebase to support it. cc @apoelstra
The text was updated successfully, but these errors were encountered: