You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Actually executing them makes the test fail. It looks like most vectors were taken from the C++ implem and therefore the Rust implem of the calculation is not on par with the C++ one.
As a part of the miniscript review for c++, I have been doing a line-by-line comparison with rust-miniscript. I still have opcode and stack size limits to double. Hopefully, will report back today/tomorrow
There are unit tests to exerce the calculation of the maximum number of elements of a satisfaction:
rust-miniscript/src/miniscript/mod.rs
Lines 586 to 631 in a2d6fff
However they are not executed...
rust-miniscript/src/miniscript/mod.rs
Line 570 in a2d6fff
Actually executing them makes the test fail. It looks like most vectors were taken from the C++ implem and therefore the Rust implem of the calculation is not on par with the C++ one.
A quick look at the first vector failing with the above patch suggests that this is the calculation that needs to be fixed: the vector looks right.
rust-miniscript/src/miniscript/mod.rs
Line 610 in a2d6fff
The text was updated successfully, but these errors were encountered: