New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added code to ignore commented lines in a bed file #474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for including the test.
Great, thanks for taking a look! Anything else that needs to be done before it can be merged? |
Last thing before merging: could you please add an entry in the changelog? |
Hi @mbhall88 I added a line the the changelog but it is my first time contributing so I hope I am following the right conventions here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that. Just one suggestion to change it to unreleased as I'm not sure whether this change will constitute a patch or minor version bump. And this way it is easier to see what has changed on the repo since the last release
Co-authored-by: Michael Hall <michael@mbh.sh>
Thanks, that is a useful way to link that I didn't know about. Thanks! |
Thanks @mrvollger. @mbhall88 - because "fix:" corresponds to a Semver patch - the now pending release is for 0.39.1. |
Added code to ignore commented lines in a bed file and also added a simple test function. I think this resolves #473.