fix: Make QGramIndex use less memory; add docs; fix bug #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added some more documentation and clarifying tests to `QGramIndex`, so that the implementation is more clear without looking at the code. I found one small bug: q-grams of value `0` (i.e. `AAA`) wouldn't be filtered by `max_count`. I've added a test that would fail if the `.skip(1)` was still there. The size of the `pos` vector was always `|text|`, but it's sufficient to only allocate memory for the number of unfiltered q-grams. Please verify this. I've added a `text="AAAAA"`, `pattern="AAA"` test that should show that things are still working.
johanneskoester
approved these changes
Feb 8, 2022
|
Thank you, good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some more documentation and clarifying tests to
QGramIndex,so that the implementation is more clear without looking at the code.
I found one small bug: q-grams of value
0(i.e.AAA) wouldn't befiltered by
max_count. I've added a test that would fail if the.skip(1)was still there.The size of the
posvector was always|text|, but it's sufficient toonly allocate memory for the number of unfiltered q-grams. Please verify
this. I've added a
text="AAAAA",pattern="AAA"test that should showthat things are still working.