feat: Backward search api #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were some issues that came up because I didn't modify the examples in the docs to use the new result type. I've fixed those now and |
|
May I ask you to format with the latest stable rust version? |
|
Done! |
tedil
reviewed
Oct 19, 2021
Comment on lines
+647
to
+654
| let positions = match sai { | ||
| BackwardSearchResult::Complete(saint) => saint.occ(&sa), | ||
| BackwardSearchResult::Partial(saint, l) => { | ||
| partial_match_len = l; | ||
| saint.occ(&sa) | ||
| } | ||
| BackwardSearchResult::Absent => Vec::<usize>::new(), | ||
| }; |
There was a problem hiding this comment.
Since we're expecting a partial match here, I think having only the corresponding Partial match arm and a panic/unreachable/... for the other two should make this (and also the other) testcase(s) clearer
There was a problem hiding this comment.
Sorry, github showed this too late to me (after merging actually). Can you (when you find the time), modify this in a separate PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the backward_search API to inform the user if there was a complete match, a partial (suffix) match, or no match during the search.