feat: Baum-Welch algorithm for Discrete HMM #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve Hidden-Markov Models Module:
* Implementation of Baum-Welch algorithm for Discrete HMM
* Creation of a Discrete Emission Module with implicity end state
* Add example usage of baum-welch
* Add tests for baum-welch and HMM discrete with end state
johanneskoester
approved these changes
Jun 21, 2021
|
Can you please format with cargo fmt? |
|
For sure! The code is now formatted. By the way, thanks for the review! I look forward to contributing more to this awesome crate. |
johanneskoester
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements related to Hidden-Markov Model Module:
* Implementation of Baum-Welch algorithm for Discrete HMM;
* Creation of a trainable Discrete Emission Module with implicit end state;
* Add tests for Baum-Welch algorithm.