Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sls | Return FAILURE status to client when internal _handle_result fails #309

Open
kunibald413 opened this issue Apr 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kunibald413
Copy link

Is your feature request related to a problem? Please describe.
Client gets response with status "COMPLETED" without any response data that the handler is adding.
This message is then observed in the sls logs:

 "message": "Failed to return job results. | 400, message='Bad Request'

log.error(f"Failed to return job results. | {err}", job['id'])

Describe the solution you'd like
Return status "FAILED" to the client when it fails to return job results. Maybe also with a message saying "internal error".
If feasible return more descriptive message on why it failed.

Additional context
Asked the client to provide the request json and upon requesting myself did not run into the issue. Response had the expected data.
The expected data is a base64 string of audio.

If the handler implementation should validate the data, in what way would the data need to be validated in order too prevent this issue?

Python 3.10.13
runpod version: 1.6.2

@kunibald413 kunibald413 added the enhancement New feature or request label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant