Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of new Buffer() (e.g. with Buffer.alloc()) #18

Closed
jacobq opened this issue Aug 17, 2018 · 1 comment
Closed

Replace use of new Buffer() (e.g. with Buffer.alloc()) #18

jacobq opened this issue Aug 17, 2018 · 1 comment

Comments

@jacobq
Copy link

jacobq commented Aug 17, 2018

It looks like here and here this code is using new Buffer() to create a Buffer object. However, current versions of node have a newer API for this, and in 10.x one will see a deprecation warning like "[DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.".

This affects downstream project as well, e.g. yarnpkg/yarn#5477

@runk
Copy link
Owner

runk commented Aug 17, 2018

Fixed in v0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants