Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin terraform versions in tests #4484

Open
1 task done
lukemassa opened this issue Apr 25, 2024 · 0 comments
Open
1 task done

Pin terraform versions in tests #4484

lukemassa opened this issue Apr 25, 2024 · 0 comments
Assignees
Labels
feature New functionality/enhancement

Comments

@lukemassa
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Describe the user story

@nitrocode recommended in #4462 (comment) that we pin terraform versions in tests. I didn't want to block that particular fix because unit tests were failing, but it seems like a good idea that I'm happy to work on.

Describe the solution you'd like

Terraform providers are pinned in tests such that external updates don't cause tests to start failing.

Describe the drawbacks of your solution

We may fall behind new features, but this is only in unit tests so the risk is low.

Describe alternatives you've considered

We could simply do nothing and live with the occasional test failure. I personally feel strongly about working to make tests idempotent and independent of changes in the "outside world", so I think pinning is the right strategy.

@lukemassa lukemassa added the feature New functionality/enhancement label Apr 25, 2024
@lukemassa lukemassa self-assigned this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

No branches or pull requests

1 participant