Does Atlantis Hide Comments work with GitHub Token?

[ehuizar1028]

I have read the documentation and found no answers. I can get my comments to hide using GitHub app, but I cannot use Gh-App due to limitations of being able to use multiple organization installations.

I cannot however get the comments to hide when using a GH Token.
Thoughts?

[jamengual]

it works on both, make sure the token has the same permissions.

…

On Thu, Feb 15, 2024 at 11:54 AM Ernesto Huizar ***@***.***> wrote: I have read the documentation and found no answers. I can get my comments to hide using GitHub app, but I cannot use Gh-App due to limitations of being able to use multiple organization installations. I cannot however get the comments to hide when using a GH Token. Thoughts? — Reply to this email directly, view it on GitHub <#4248>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ3ERGGDHHXW23MDBSJQ3LYTZRZFAVCNFSM6AAAAABDK3X42WVHI2DSMVQWIX3LMV43ERDJONRXK43TNFXW4OZWGIZDGNJYG4> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[ehuizar1028]

thank you! although i tried with the PAT token having full permissions, all boxes checked, and did not hide any comments. I tried it a few minutes ago. Not sure if it matters, but it's running against an Enterprise server.

I also made sure all required boxes from the following docs were set in the webhook and PAT
https://www.runatlantis.io/docs/configuring-webhooks.html#github-github-enterprise

https://www.runatlantis.io/docs/access-credentials.html#github-user

Also ensured atlantis_hide_prev_plan_comments was set to true.

And also no errors in the logs refusing to hide comments.

[jamengual]

are you testing with Debug enabled?

…

On Thu, Feb 15, 2024, 1:28 p.m. Ernesto Huizar ***@***.***> wrote: thank you! although i tried with the PAT token having full permissions, all boxes checked, and did not hide any comments. I tried it a few minutes ago. Not sure if it matters, but it's running against an Enterprise server. I also made sure all required boxes from the following docs were set in the webhook and PAT https://www.runatlantis.io/docs/configuring-webhooks.html#github-github-enterprise https://www.runatlantis.io/docs/access-credentials.html#github-user Also ensured atlantis_hide_prev_plan_comments was set to true. And also no errors in the logs refusing to hide comments. — Reply to this email directly, view it on GitHub <#4248 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ3ERCT5MAECQ7P6OG3473YTZ4WVAVCNFSM6AAAAABDK3X42WVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4DIOBVG4YTM> . You are receiving this because you commented.Message ID: ***@***.***>

[ehuizar1028]

thanks! i did turn on debugging just now. displaying the following info. Not sure if the value 1 means failure or success? But the Hide is unsuccessful from the PR side.
As a timer and counter metric.

{
  "name": "atlantis.github.hide_prev_plan_comments.execution_success", 
  "value": 1
}

{
  "name": "atlantis.github.hide_prev_plan_comments.execution_time", 
  "value": 0.062148409
}