New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support external repositories and generated sources #158
Comments
Do you have an example failing repo for either case? We test the first case pretty comprehensively, since a lot of tests depend on We test the second case here: https://github.com/rules-proto-grpc/rules_proto_grpc/tree/master/test_workspaces/generated_proto |
Ah, let me double-check. One error I see are all from when both cases are combined, i.e. my proto has a dependency on a generated proto in a different repository. Something like this:
And here The other error is when the generated proto is a dependency of another proto. In your example, I would try having another proto file depend on |
Ok, thanks, sounds like I need to extend that test workspace and see if I can replicate the issue. |
Thanks! I could try and make a complete repro available somehow, but let me know if you get to any problems yourself! |
I've updated the test workspace to (I think) include the above suggestions and I still can't get it to fail:
This has both static and generated proto in a workspace depending on a generated proto from another workspace. I think I'm going to need that repro repo 😄 |
Thank you! OK, one thing at a time. The following use of a generated proto as a dependency of an on-disk proto causes an error for me:
Building:
The on-disk proto Can you reproduce that error? I'll try to make a minimal repro for the external repo next. Thanks a lot! |
Another issue with dependencies on generated protos arises when using the Python bindings. Extend the above as follows:
|
I wonder if these issues also affected the external-repo case I had, so maybe let's concentrate on these two first, and then revisit the external repos afterwards. |
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further. |
Description
I have seen failures in generated C++ and Python code when using a
proto_library
with (any of) the following properties:the proto depends on (= imports) a proto from a different repository, i.e. the dependency is of the form
@other//path/to:foo_proto
.the proto depends on a proto with generated sources, i.e. on a
proto_library
whosesrcs
are the output of, say, agenrule
.Could you perhaps check if you have test coverage for those cases?
The text was updated successfully, but these errors were encountered: