Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt upstream version scheme #369

Open
jlaine opened this issue Jul 20, 2023 · 3 comments
Open

Adopt upstream version scheme #369

jlaine opened this issue Jul 20, 2023 · 3 comments

Comments

@jlaine
Copy link

jlaine commented Jul 20, 2023

First of all thanks for providing this library, it's still the most convenient way to install libphonenumber out there!

Since what this package provides is an unmodified version of the upstream library, wouldn't it make sense to just use the same version number?

This would make it much easier to track which upstream version you are providing. It is also the approach taken by the Python version of libphonenumber: https://github.com/daviddrysdale/python-phonenumbers

@ruimarinho
Copy link
Owner

I think this makes sense. I don't see an immediate problem with upgrading from v3 (current) to v8.

@jlaine
Copy link
Author

jlaine commented Aug 21, 2023

Cool! Once you make this change, I'd be happy to provide a PR for an automated GitHub action which periodically checks whether the local version matches the upstream version so you don't need to monitor the libphonenumber mailing list.

I did the same for the Python package: daviddrysdale/python-phonenumbers#275

@jlaine
Copy link
Author

jlaine commented Nov 24, 2023

Hi @ruimarinho I hope you are well? Have you given any additional thought to my suggestion of adopting the upstream numbering?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants