Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonJS modules #353

Open
StaysenseWesMelton opened this issue Dec 13, 2022 · 2 comments
Open

CommonJS modules #353

StaysenseWesMelton opened this issue Dec 13, 2022 · 2 comments

Comments

@StaysenseWesMelton
Copy link

Any chance you could update the build process to export modules so TS apps can use this library without importing the entire library before doing destructuring?

@riderx
Copy link

riderx commented Dec 16, 2022

i got this message if that can help

[ng] Warning: ./node_modules/@capgo/ngx-intl-tel-input/fesm2020/capgo-ngx-intl-tel-input.mjs depends on 'google-libphonenumber'. CommonJS or AMD dependencies can cause optimization bailouts.
[ng] For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
[ 

So for me even splitted lib could be better

@ruimarinho
Copy link
Owner

I'm all for it but I don't really have the time to do it at the moment. If anyone is interested in doing a PR, I'll be glad to take a look.

I think the real difficulty here is the dependency on Google Closure though. If Google moved away from it, it would be so much easier to use the upstream version..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants