Recreate screenhots and screencasts in new Firefox design #268
Comments
rugk
added
good first issue
|
Sounds pretty straightforward! I can tackle it if you want to go ahead and assign me. I can knock it out some time today or tomorrow. |
|
Thanks a lot for taking this on! 😃 Feel free to send a PR if you've done it. |
|
Thanks! How exact did you want the new screenshots to match the old ones @rugk? I can get the dimensions to match easily but do you also want the exact same Firefox themeing, etc.? |
|
It does not have to be exactly the same (pixel size), but the same general theme e.g. would be quite nice. |
|
A little busier IRL than I thought I'd be, sorry! The English screenshots are done, just need to do the screencasts and screenshot the German settings. |
|
Oh sure, thanks a lot! Did not even remember I screenshott'ed the German settings separately, that is nice. |
|
Alright, sorry for the delay! Pull request #271 has the new screenshots and screencaps. |
|
Thanks a lot, no problem. Take the time you need. 🙂 |
|
Hi there. Is this task still available? I would like to offer my assistance if possible |
|
Sure it is, so I assign it to you @Tch4lla then. 🙂 Thanks for your work already. 🙂 |
rugk
added
the
hacktoberfest
|
Is this issue resolved? I want to contribute in it. |
|
I have already submitted my pull request for this issue, and am currently waiting on confirmation if there are any changes or tweaks that need to be made. |
|
Indeed, #284 is the PR to fix these, Sorry for the delay, I was busy and missed the notifications. I assume, if help is needed, @RohitRajvaidya5 you can jump in and help here. Feel free to test or review the existing PR, BTW. |
|
Ahh, thank you for getting back to me
You have left some great advice and I will try to implement those this
week.
…On Wed, Oct 19, 2022 at 10:19 PM rugk ***@***.***> wrote:
Indeed, #284 <#284> is the PR
to fix these, Sorry for the delay, I was busy and missed the notifications.
I assume, if help is needed, @RohitRajvaidya5
<https://github.com/RohitRajvaidya5> you can jump in and help here. Feel
free to test or review the existing PR, BTW.
—
Reply to this email directly, view it on GitHub
<#268 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXYA7KYGKAK26SZYOPLDT4DWD7YPXANCNFSM5CISSKIA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
I have made those adjustments and have submitted and updated pull request. I hope that it is not too much work to merge |
The screenshots still follow the old Photon (tab) design, which of course does not
The new design with floating tabs looks very much different. So all images and screencasts need to be re-made.
If anyone wants to contribute, this is a very easy task! You see all files in the
assets/screencastsandassets/screenshotsdirectories. You just need to look at them and do/screenshot (exactly) the same in a new modern Firefox (stable or even Firefox Developer Edition is enough), replace all files and create and submit a Pull Request.Also mind to keep the pixel sizes (width/height) of the GIFs/images approximately the same, as they were optimized for the display on addons.mozilla.org (AMO) etc.
The text was updated successfully, but these errors were encountered: