Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add-on linting shows some warnings regarding eval/innerHtml usage #248

Open
rugk opened this issue May 31, 2020 · 1 comment
Open

Add-on linting shows some warnings regarding eval/innerHtml usage #248

rugk opened this issue May 31, 2020 · 1 comment
Labels
blocked This issue is blocked by something from the outside and cannot be done currently. bug Something isn't working

Comments

@rugk
Copy link
Owner

rugk commented May 31, 2020

Bug description

When the add-on is linted for inclusion in Firefox add-on store, we get some warnings, because of eval functions being used.

The source is https://unpkg.com/kjua-svg@1.10.0/kjua.min.js

Steps to reproduce

  1. Lint with web-ext, respectively their tool.

Actual behavior

Some innerHTML/eval warnings are generated:
image

Expected behavior

No warnings.

System

Operating system and version: N/A
Browser and version: N/A
Add-on version: f8caf56

Possible solution

kjua-svg needs to fix/address this
@rugk rugk added the bug Something isn't working label May 31, 2020
@rugk rugk mentioned this issue May 31, 2020
Closed
@rugk
Copy link
Owner Author

rugk commented May 31, 2020

Reported upstream/blocked by werthdavid/kjua#4

@rugk rugk added the blocked This issue is blocked by something from the outside and cannot be done currently. label May 31, 2020
@rugk rugk changed the title Add-on linting creates some issues Add-on linting shows some warnings regarding eval/innerHtml usage May 31, 2020
rugk added a commit that referenced this issue May 31, 2020
@rugk
Add AMO review note
585cfd5 
Regarding kjua-svg.

Ref #248
@rugk rugk mentioned this issue Jul 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked This issue is blocked by something from the outside and cannot be done currently. bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rugk