Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forms for special URLs (Wifi, mailto) #213

Open
Marwe opened this issue Jul 30, 2019 · 5 comments
Open

Add forms for special URLs (Wifi, mailto) #213

Marwe opened this issue Jul 30, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@Marwe
Copy link

Marwe commented Jul 30, 2019

QR codes are especially useful for passwords and all types of adresses you don't want to type on a small smart phone screen. Predefined forms could help users to create the syntactically correct string.

To my mind come the following use cases:

  1. Wifi connections:
    1.1 for WPA2 connections adapt the following strings WIFI:S:$YOUR_SSID;T:WPA;P:$YOUR_PASSWORD;;
    1.2 For WPA2-EAP: WIFI:T:WPA2-EAP;S:[network SSID];H:[hidden?];E:[EAP method];PH2:[Phase 2 method];AI:[anonymous identity];I:[username];P:[password];;, e.g. WIFI:S:YOUR_ESSID;T:WPA2-EAP;AI:anonymous@domain.tld;I:username@domain.tld;P:YOUR_PASSWORD;E:PEAP;PH2:MSCHAPV2;;
  2. mailto: mailto:username@domain.tld?subject=Mail%20title?body=Hello%20my%20dear
  3. Full adress book entries (feature for thunderbird?): use vcf export file content as string

This is label:enhancement

@rugk rugk added the enhancement New feature or request label Jul 30, 2019
@rugk
Copy link
Owner

rugk commented Jul 30, 2019

  1. may be a little complex (especially as we would need to "upload"/input files or so)
    Though 1. and 2. may be a good idea feature-wise, but I have no idea how to include it in the UI/create it UI-wise.

BTW next time, better just use the issue template. (select the correct one when creating the issue)

@Marwe
Copy link
Author

Marwe commented Aug 2, 2019

Thanks for looking at it,

no idea how to include it in the UI

Would it be possible to show a local page with some forms in it? Then filling values in there and selecting (resulting properly formatted) text would give an opportunity to use "create from selection". 1 needs some template text, 2 also needs URL-encoding, which should be easy with js (dunno how, since I am not coding in js).

  1. may be a little complex

agreed, vcf could be copy-pasted right now, but most people are unable to open a file with a text editor O_o, and opening as text with browser is also not so easy (mime type check)...

use the issue template.

Sorry, did not see it when creating. Weird, since now it seems mandatory and natural...

@jamescallumyoung
Copy link

jamescallumyoung commented Oct 15, 2019

@Marwe I'd like to take this up. I've been wanting this feature too and it doesn't look too hard.

Since there's no menus at the moment I'll do the usual "material" thing and add a header with a menu button, and a sidebar with each of these (1.1, 1.2, 2) as options.

Let me know what you think. I could add these as context menu options too but then it might be a bit hidden from the user.

@rugk
Copy link
Owner

rugk commented Oct 15, 2019

@jamescallumyoung First, thanks for taking this up.

However, I really want to avoid a material UI like thing. (i.e. no useless title bar, this is a waste of screen space)

If you want to add a menu, please try to add some floating menu (rounded corner) with an icon or so that just opens a sidebar.

Also mind that more features may be added to that menu. In #52 (comment) I also had to think about this there, and this still stands:

click on toolbar button -> select some button there (note this button should of course not overlay the shown QR code, maybe just move in a bit when hovered) OR use context menu entry

Maybe you do not have to take away too much space from the QR code, but IMHO just add this "hover in" thing at the top right or left, which opens a menu. 😃

It could also already expose all menu options/entries, and you just hover over them to see them all… 🤔

(And actually a context menu entry for this feature would likely be quite complicated, as it needs to trigger the popup opening. So rather focus on the menu, but if you get a context menu entry too, that would of course be awesome. 😃 )

This was referenced Oct 15, 2019
@jamescallumyoung
Copy link

I added a new feature request for the menu so we can keep this feature focused on the "forms for special URLs".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants