Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awkward insertion on Facebook comments #38

Open
Prometheos2 opened this issue May 24, 2019 · 9 comments
Open

Awkward insertion on Facebook comments #38

Prometheos2 opened this issue May 24, 2019 · 9 comments
Labels
bug Something isn't working site-issue This issue is about a specific incompatible website.

Comments

@Prometheos2
Copy link
Contributor

Prometheos2 commented May 24, 2019

I've no been able to pinpoint the source of the problem, but it seems that when you insert two emoji quickly, the focus on the comment is loss and it either insert the emoji at the beginning, or reinsert your own comment at the end of the original.

1st click: works normally
2nd click: insert at the beginning
3rd click: the comment is duplicated, along with the emoji inserted at the beginning of the duplicated message
image

And removing the first weird unicode emoji results in the comment box being closed ad infinitum

@rugk rugk added bug Something isn't working site-issue This issue is about a specific incompatible website. labels May 25, 2019
@rugk
Copy link
Owner

rugk commented May 25, 2019

Thanks for the report. This looks similar to how GitHub gist behaved for me…

Can you have a look at https://gist.github.com/ and test it there (insert emojis into the code area)?
See issue #20 for details.

@Prometheos2
Copy link
Contributor Author

Yeah, it does the same problem.

It doesn't close the gist box, but it doesn't allow to click away from the last character.

@Prometheos2
Copy link
Contributor Author

Update: It breaks at the 2nd insertion, not only the 3rd one.

@Prometheos2
Copy link
Contributor Author

Prometheos2 commented Apr 7, 2020

Similarly to what I said on #37, the new version of the website leads to the Messenger being affected by the glitch.

Inserting a second emoji leads to the first being duplicated; leading to 3 emojis. A third insertion leads to 7 emojis.

The two first ones are anomalous and trying to delete them lead to Messenger crashing.
The first half of the remaining can't be deleted.

EDIT: I can't grasp the logic behind it

Some can't be deleted; some induce a crash if you attempt to delete them while there are no normal emojis.
As long as there are "healthy" emojis, the crash-inducers can't be deleted either, and an attempt to will delete a healthy emoji.

In this picture, we have 4 insertions.
The blue square represents the crash-inducing emojis, the orange represents the undeletable ones, the rest are the healthy ones.

image

@rugk
Copy link
Owner

rugk commented Apr 7, 2020

What do you mean by "induce a crash"?
How exactly does the web app crash? Does it really cause a crash of the whole tab?

@rugk
Copy link
Owner

rugk commented Apr 7, 2020

BTW given this only affects Facebook sites, I've had a quick look on whether this is a React issue.
So e.g. I'll try out the editor in https://mpkelly.github.io/react-editor-kit/ and the result is:

  • auto-insertion works, basically
  • pasting an emoji into the editor, however, duplicates it

Maybe you can play around there a little bit and try to reproduce the problem.

Edit: wait, I actually could see the "crash", the whole websites just goes white, does not it?

Console message:

Error: "Cannot resolve a DOM point from Slate point: {"path":[1,2,4],"offset":8}"

@Prometheos2
Copy link
Contributor Author

For me, it's the whole Messenger's tabs disappearing, and a warning sign appearing.

The connection to wss://edge-chat.facebook.com/chat?region=ash&sid=3715573164802047 was interrupted while the page was loading.

ErrorUtils caught an error:

Node.removeChild: The node to be removed is not a child of this node [Caught in: ErrorBoundary MWChatMain]

image

@rugk
Copy link
Owner

rugk commented Apr 7, 2020

For me, it's the whole Messenger's tabs disappearing, and a warning sign appearing.

Could you provide a screenshot? The one at the bottom apparently shows something else, as the messenger tab is still there??

@Prometheos2
Copy link
Contributor Author

Prometheos2 commented Apr 8, 2020

The column with the active friends remains, even when the tabs/conversations part crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working site-issue This issue is about a specific incompatible website.
Projects
None yet
Development

No branches or pull requests

2 participants