Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear effect of add_function type parameter #303

Open
kapcod opened this issue Feb 20, 2024 · 0 comments
Open

Unclear effect of add_function type parameter #303

kapcod opened this issue Feb 20, 2024 · 0 comments

Comments

@kapcod
Copy link

kapcod commented Feb 20, 2024

In all the add_function examples you pass :numeric type, but there's no clear explanation why this type needed and how it affects the functionality. I experimented with this and couldn't see any effect it does. There's no type casting in case I wrote :numeric but function receives or returns string. I could even pass some garbage as type and it still worked exactly the same.
If this type is not needed, maybe you can drop it (or make optional for back-compatibility)?
If it does anything, maybe add a few lines of documentation?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant