Make sure arithmetic performed by custom class is not raising error #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignatiusreza
force-pushed
the
feat/unit-calculation
branch
2 times, most recently
from
a290a08
to
98e0eae
Compare
ignatiusreza
force-pushed
the
feat/unit-calculation
branch
from
98e0eae
to
772ebe1
Compare
|
💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #297
Arithmetic on custom classes was working as expected until the changes in 2246cb9 .. Given that the library already have existing test cases for this for some other data type and operation (e.g. array, addition with custom classes, etc); I think it make sense to make sure that other operations are also working as expected..