Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scanning .gemspec files #307

Open
reedloden opened this issue May 28, 2021 · 2 comments
Open

Support scanning .gemspec files #307

reedloden opened this issue May 28, 2021 · 2 comments

Comments

@reedloden
Copy link
Member

I noticed that GitHub's Dependabot checks .gemspec files, as well as Gemfile.lock. We should do the same, as it would let bundler-audit monitor gems directly.

They also check other files as well, so may also want to add that.

See https://github.com/dependabot/dependabot-core/tree/main/bundler/lib/dependabot/bundler for how they do it.

@postmodern
Copy link
Member

postmodern commented May 29, 2021

I believe bundler already includes any dependencies from the .gemspec into Gemfile.lock, if the Gemfile contains gemspec.Also .gemspec does not contain the exact gem versions, but only the version ranges, so we'd need additional logic for determining whether a version range intersects with a vulnerable version range.

@postmodern
Copy link
Member

It might be useful for indicating to the user that they need to change the version range in the .gemspec vs just running bundle update, but that would require some clever to logic to detect overly strict version ranges in the .gemspec vs. the Gemfile.lock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants