New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make no distinction between arm64-darwin-{21,22,23} #7407
Comments
Agree with this, not sure what the purpose is of also including the Darwin kernel version in the lockfile, as it's not done for the other architectures either? @deivid-rodriguez could you maybe shed some light on this? Thanks in advance 😄 |
We can easily normalize that with https://github.com/rubygems/rubygems/blob/master/lib/rubygems/platform.rb#L118. But I'm not sure what breaking impact with this change. Does anyone survey that? |
I think unknown platforms are just ignored. Any platform allowed(?)So for example this platform list in
Would not cause any trouble when running Automatic cleanupHowever, we would be left with some "junk platforms" in the gem lockfile. Perhaps a temporary addition to |
We just parse what Ruby gives us as I agree that Darwin versions are not really different in practice? But not sure. I know people have actually released platform specific gems for different darwin versions but maybe they are actually all equal in code, and that's just due to how RubyGems and Bundler handle platforms right now. I'm also not sure about backwards compatibility. One thing to note is that since recently, if no darwin version specific precompiled gems are found among resolved gems, Bundler won't lock specific version platforms, but the generic one, like requested here. So this is only a limited problem right now because most popular gems releasing precompiled versions don't ship |
Ah, good to know. Seems like |
When running macOS with an ARM processor, our
Gemfile.lock
looks like this:This doesn't make sense to me, there is no discernible difference between 21/22/23.
I think it would make more sense if it looked like this:
(i.e. that the mac platform wouldn't get a bump every year)
Semi-related
The text was updated successfully, but these errors were encountered: