Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests when ran locally. #227

Open
duckinator opened this issue Mar 30, 2019 · 3 comments
Open

Failing tests when ran locally. #227

duckinator opened this issue Mar 30, 2019 · 3 comments

Comments

@duckinator
Copy link
Member

I tried to get a working development environment for gemstash. I couldn't find any documentation on doing so, so I did my usual approach:

$ git clone https://github.com/bundler/gemstash.git
$ cd gemstash
$ bundle install
$ bundle exec rake spec

And bundle exec rake spec gave this output: https://gist.github.com/duckinator/0e9088d0f24281170b6dfb1518514d39

There appears to be two distinct errors.

The first is this, which I have also encountered with Bundler:

       ERROR:  While executing gem ... (NameError)
           uninitialized constant Gem::RDoc
     # ./spec/integration_spec.rb:204:in `block (4 levels) in <top (required)>'

The second is this one, which I find very strange because I'm... running it through bundler 2.0.1:

       /usr/local/share/ruby/site_ruby/rubygems.rb:283:in `find_spec_for_exe': Could not find 'bundler' (2.0.1) required by `$BUNDLER_VERSION`. (Gem::GemNotFoundException)
       To update to the latest version installed on your system, run `bundle update --bundler`.
       To install the missing version, run `gem install bundler:2.0.1`
       	from /usr/local/share/ruby/site_ruby/rubygems.rb:302:in `activate_bin_path'
       	from /home/pup/.gem/ruby/bin/bundle:23:in `<main>'
     Shared Example Group: "a bundleable project" called from ./spec/integration_spec.rb:251

Any ideas where to start poking at this?

@bronzdoc
Copy link
Member

Hi @duckinator

We have a Development section in the README i tried the instructions there to set up Gemstash and works well, i can't reproduce the errors you are getting, maybe this is a problem with your ruby environment and not a Gemstash issue?

@duckinator
Copy link
Member Author

Hi, sorry for disappearing before.

I came up with a testcase. This will reproduce the errors about Bundler (plus a few others), then print "Bundler version 2.0.1":

docker run --rm -it fedora:29 /bin/bash -c "dnf install -y redhat-rpm-config ruby ruby-devel libffi libffi-devel git sqlite-devel @development-tools && git clone https://github.com/bundler/gemstash.git && cd gemstash && gem install bundler && ./bin/setup && bundle exec rake; bundle --version"

Whereas this has only 2 errors (unrelated to Bundler versions), then prints "Bundler version 1.17.2":

docker run --rm -it ruby:2.6-slim /bin/bash -c "apt update && apt install -y git libsqlite3-dev build-essential && git clone https://github.com/bundler/gemstash.git && cd gemstash && ./bin/setup && bundle exec rake; bundle --version"

Given the Bundler versions and the errors, that is the exact opposite behavior of what I'd expect.

phanle pushed a commit to Gusto/gemstash-public-fork-archive that referenced this issue Aug 12, 2019
199: Update rack-test requirement from ~> 0.6 to ~> 1.1 r=bronzdoc a=dependabot[bot]

Updates the requirements on [rack-test](https://github.com/rack-test/rack-test) to permit the latest version.
<details>
<summary>Release notes</summary>

*Sourced from [rack-test's releases](https://github.com/rack-test/rack-test/releases).*

> ## v1.1.0
> ## 1.1.0 / 2018-07-21
> 
> * Breaking changes:
>   * None
> 
> * Minor enhancements / new functionality:
>   * [GitHub] Added configuration for Stale (Per Lundberg [rubygems#232](https://github-redirect.dependabot.com/rack-test/rack-test/issues/232))
>   * `follow_direct`: Include `rack.session.options` (Mark Edmondson [rubygems#233](https://github-redirect.dependabot.com/rack-test/rack-test/issues/233))
>   * [CI] Add simplecov (fatkodima [rubygems#227](https://github-redirect.dependabot.com/rack-test/rack-test/issues/227))
> 
> Bug fixes:
>   * Follow relative locations correctly. (Samuel Williams [rubygems#230](https://github-redirect.dependabot.com/rack-test/rack-test/issues/230))
</details>
<details>
<summary>Changelog</summary>

*Sourced from [rack-test's changelog](https://github.com/rack-test/rack-test/blob/master/History.md).*

> ## 1.1.0 / 2018-07-21
> 
> * Breaking changes:
>   * None
> 
> * Minor enhancements / new functionality:
>   * [GitHub] Added configuration for Stale (Per Lundberg [rubygems#232](https://github-redirect.dependabot.com/rack-test/rack-test/issues/232))
>   * follow_direct: Include rack.session.options (Mark Edmondson [rubygems#233](https://github-redirect.dependabot.com/rack-test/rack-test/issues/233))
>   * [CI] Add simplecov (fatkodima [rubygems#227](https://github-redirect.dependabot.com/rack-test/rack-test/issues/227))
> 
> Bug fixes:
>   * Follow relative locations correctly. (Samuel Williams [rubygems#230](https://github-redirect.dependabot.com/rack-test/rack-test/issues/230))
> 
> ## 1.0.0 / 2018-03-27
> 
> * Breaking changes:
>   * Always set CONTENT_TYPE for non-GET requests
>     (Per Lundberg [rubygems#223](https://github-redirect.dependabot.com/rack-test/rack-test/issues/223))
> 
> * Minor enhancements / bug fixes:
>   * Create tempfile using the basename without extension
>     (Edouard Chin [rubygems#201](https://github-redirect.dependabot.com/rack-test/rack-test/issues/201))
>   * Save `session` during `follow_redirect!`
>     (Alexander Popov [rubygems#218](https://github-redirect.dependabot.com/rack-test/rack-test/issues/218))
>   * Document how to use URL params with DELETE method
>     (Timur Platonov [rubygems#220](https://github-redirect.dependabot.com/rack-test/rack-test/issues/220))
> 
> ## 0.8.3 / 2018-02-27
> 
> * Bug fixes:
>   * Do not set Content-Type if params are explicitly set to nil
>     (Bartek Bułat [rubygems#212](https://github-redirect.dependabot.com/rack-test/rack-test/issues/212)). Fixes [rubygems#200](https://github-redirect.dependabot.com/rack-test/rack-test/issues/200).
>   * Fix `UploadedFile#new` regression
>     (Per Lundberg [rubygems#215](https://github-redirect.dependabot.com/rack-test/rack-test/issues/215))
> 
> * Minor enhancements
>   * [CI] Test against Ruby 2.5 (Nicolas Leger [rubygems#217](https://github-redirect.dependabot.com/rack-test/rack-test/issues/217))
> 
> ## 0.8.2 / 2017-11-21
> 
> * Bug fixes:
>   * Bugfix for `UploadedFile.new` unintended API breakage.
>     (Per Lundberg [rubygems#210](https://github-redirect.dependabot.com/rack-test/rack-test/issues/210))
> 
> ## 0.8.0 / 2017-11-20
> 
> * Known Issue
>   * In `UploadedFile.new`, when passing e.g. a `Pathname` object,
>     errors can be raised (eg. `ArgumentError: Missing original_filename
>     for IO`, or `NoMethodError: undefined method 'size'`) See [rubygems#207](https://github-redirect.dependabot.com/rack-test/rack-test/issues/207), [rubygems#209](https://github-redirect.dependabot.com/rack-test/rack-test/issues/209).
></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- See full diff in [compare view](https://github.com/rack-test/rack-test/commits/v1.1.0)
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

Co-authored-by: dependabot[bot] <support@dependabot.com>
@olleolleolle
Copy link
Member

👋 Hi!

I did the steps indicated in the original post, now quite old, and I had to tell my shell to allow more file handles: I took this from the CI configuration, and then all the tests ran to completion, no failures.

ulimit -n 8192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants