Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore disabling InventoryItem #4333

Open
1 task
awwaiid opened this issue May 5, 2024 · 3 comments
Open
1 task

Explore disabling InventoryItem #4333

awwaiid opened this issue May 5, 2024 · 3 comments
Assignees
Labels
core team Groomed but likely needs expert knowledge

Comments

@awwaiid
Copy link
Collaborator

awwaiid commented May 5, 2024

Summary

When the Event system is fully adopted we'll want to remove InventoryItems altogether. As a step in that direction, for this ticket explore turning InventoryItem writes into a NOP or experimenting with removing it altogether. Then run the tests / interactive in Event mode and see what breaks!

Things to consider

No response

Criteria for Completion

  • Recommend a strategy or provide a initial step to removing InventoryItems
@awwaiid awwaiid added the core team Groomed but likely needs expert knowledge label May 5, 2024
@dorner
Copy link
Collaborator

dorner commented May 10, 2024

Started looking at this... there really isn't a way to do this halfway and validate it. A whole crapload of specs fail because they're testing very specific methods or items that won't exist. Basically the end result of this would be a branch where all reference to inventory items and any method that deals with them are completely expunged.

One thing that tripped me up is that a bunch of specs do storage_location.items, which goes through inventory_items and which fail a lot. :(

@cielf
Copy link
Collaborator

cielf commented May 16, 2024

Hmm. I'm not sure that I've throughly tested the inventory history feature with event sourcing. I expect we'll need to have it only go back to the snapshot date, yes?

@dorner
Copy link
Collaborator

dorner commented May 17, 2024

Yep. We can only show history via events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core team Groomed but likely needs expert knowledge
Projects
None yet
Development

No branches or pull requests

3 participants