Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional signature line to distribution printout #4312

Closed
4 tasks
cielf opened this issue Apr 28, 2024 · 4 comments · Fixed by #4342
Closed
4 tasks

Add optional signature line to distribution printout #4312

cielf opened this issue Apr 28, 2024 · 4 comments · Fixed by #4342
Assignees

Comments

@cielf
Copy link
Collaborator

cielf commented Apr 28, 2024

Summary

Some (but not all) banks use the distribution printout as a receipt, requiring a signature from the partner on pickup or delivery. Add that at the end of the printout, optionally

Details

The flag for inclusion should be on an organization level, default to false

The added lines should be (adjust to fit the 8.5 x 11 page):
Received by:
(Print Name) _____________________________ (Signature and Date) ________________________________
Delivered by:
(Print Name) _____________________________ (Signature and Date) ________________________________

Note: One bank is using the comments as a workaround for this.

Criteria for completion:

  • Option to add signature lines to distribution printout (receipt) added to organization - editable and showing.
  • That option controls the inclusion of the signature lines on the distribution printout
  • Tests to support the above functionality
  • Provide a screenshot in the PR
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Apr 28, 2024
@sean-dickinson
Copy link
Collaborator

I'd be happy to take this one

@dorner
Copy link
Collaborator

dorner commented May 6, 2024

You got it!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label May 6, 2024
@sean-dickinson
Copy link
Collaborator

@dorner I'm curious to hear what you were thinking in terms of testing this functionality. It doesn't look like there's anything currently set up for testing this pdf generation or for any other similar flag functionality on the organization. I'd be happy to test it out, but I'm not sure the best way.

@dorner
Copy link
Collaborator

dorner commented May 7, 2024

Good question. Most of the functionality here is visual, which tests wouldn't be able to show. I think a minimal test that shows that the result generates, without crashing, and without any specific expectations on the output, should be fine. If we don't have that, it'd be a good idea to add it for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants