Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove organization from superuser edit/index of users #4296

Open
4 tasks
cielf opened this issue Apr 21, 2024 · 1 comment · May be fixed by cancelei/rails-human-essentials#5
Open
4 tasks

Remove organization from superuser edit/index of users #4296

cielf opened this issue Apr 21, 2024 · 1 comment · May be fixed by cancelei/rails-human-essentials#5
Assignees

Comments

@cielf
Copy link
Collaborator

cielf commented Apr 21, 2024

Summary

You currently have to add an organization if you edit a user as a superuser. We don't need the link to the organization on the user at all anymore -- it's handled through the user's roles.

Why fix?

Outdated. This is not a high priority item, as it the function it is on is very rarely used.

Details

Note: Although this is ranked beginner, it does need some familiarity with the system. Please don't take this as your first issue.

Now that we have roles, users are no longer tied to organizations directly. The organization field can, therefore, be removed from the user entirely.

User in the superadmin interface is affected by this

Edit.
Remove the user-level organization from this view.

Index.
The organization column was good information to have for the organizations that have it -- can we list the organizations and partners that the user belongs to, through their roles, here instead? Rename the column "Banks and Partners"

New: Analagous changes to new are being handled with a different issue.

Sanity check.
We're pretty sure that's the only remaining place that User.organization is used. However, please do check. (If we're wrong, existing tests should fail, we hope.)

Criteria for completion

  • functionality as described
  • tests added and/ or modified to support the new functionality
  • tests work!
  • Please include screenshots in your PR
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Apr 21, 2024
@cancelei
Copy link
Contributor

I can take this one!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants