Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed improvement -- Children should have unique names #4295

Closed
1 task
cielf opened this issue Apr 21, 2024 · 3 comments · Fixed by #4375
Closed
1 task

Seed improvement -- Children should have unique names #4295

cielf opened this issue Apr 21, 2024 · 3 comments · Fixed by #4375
Assignees
Labels
Good First Issue Suitable for users that are newer or less experienced stale

Comments

@cielf
Copy link
Collaborator

cielf commented Apr 21, 2024

Summary

Children in the seed data should have non-repeating names.

Why?

Reduce developer confusion

Details

Currently, we have a lot of kids in the seed data who have the same name, just different birthdates. while these are technically different kids (and the situation could happen in real life), it's just confusing when you start working with children.
Change the seed so that the children have unique combinations of first and last name (either may repeat)

Criteria for completion

  • The children in the seed data have unique names.
@cielf cielf added the Good First Issue Suitable for users that are newer or less experienced label Apr 21, 2024
@Trevor-Robinson
Copy link
Contributor

I'd love to take this one if possible.

@cielf
Copy link
Collaborator Author

cielf commented Apr 25, 2024

Sounds good!

Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for users that are newer or less experienced stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants